lkml.org 
[lkml]   [2022]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/6] gpiolib: cdev: simplify linereq_free
From
On 7/13/22 7:03 PM, Kent Gibson wrote:
> The edge detector is only ever started after the line desc has been
> determined, so move edge_detector_stop() inside the line desc check,
> and merge the two checked regions into one.
>
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
> drivers/gpio/gpiolib-cdev.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> index 0c9a63becfef..b44526e3630e 100644
> --- a/drivers/gpio/gpiolib-cdev.c
> +++ b/drivers/gpio/gpiolib-cdev.c
> @@ -1460,15 +1460,15 @@ static ssize_t linereq_read(struct file *file,
> static void linereq_free(struct linereq *lr)
> {
> unsigned int i;
> - bool hte = false;
> + bool hte;
>
> for (i = 0; i < lr->num_lines; i++) {
> - if (lr->lines[i].desc)
> + if (lr->lines[i].desc) {
> hte = !!test_bit(FLAG_EVENT_CLOCK_HTE,
> &lr->lines[i].desc->flags);
> - edge_detector_stop(&lr->lines[i], hte);
> - if (lr->lines[i].desc)
> + edge_detector_stop(&lr->lines[i], hte);
> gpiod_free(lr->lines[i].desc);
> + }
> }
> kfifo_free(&lr->events);
> kfree(lr->label);

Acked-by: Dipen Patel <dipenp@nvidia.com>

\
 
 \ /
  Last update: 2022-07-15 07:11    [W:0.555 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site