Messages in this thread | | | Date | Mon, 18 Jul 2022 17:46:20 +0800 | From | Kent Gibson <> | Subject | Re: [PATCH v2 5/6] gpiolib: cdev: consolidate edge detector configuration flags |
| |
On Mon, Jul 18, 2022 at 11:33:48AM +0200, Linus Walleij wrote: > On Thu, Jul 14, 2022 at 4:04 AM Kent Gibson <warthog618@gmail.com> wrote: > > > Combine the polarity_change flag, struct line eflags, and hte enable > > flag into a single flag variable. > > > > The combination of these flags describes the configuration state > > of the edge detector, so formalize and clarify that by combining > > them into a single variable, edflags, in struct line. > > > > The edflags is a subset of the GPIO_V2_LINE_FLAGsb relevant to > > What is that "b" at the end of GPIO_V2_LINE_FLAGsb? > Oh well no big deal. Bart can fix when applying if it is disturbing. >
Yeah, typo or something - no idea what that is doing there, but it has been there since v1. ¯\_(ツ)_/¯ Bart - please do fix that if you don't mind.
Thanks for the review.
Cheers, Kent.
| |