Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 18 Jul 2022 11:33:48 +0200 | Subject | Re: [PATCH v2 5/6] gpiolib: cdev: consolidate edge detector configuration flags |
| |
On Thu, Jul 14, 2022 at 4:04 AM Kent Gibson <warthog618@gmail.com> wrote:
> Combine the polarity_change flag, struct line eflags, and hte enable > flag into a single flag variable. > > The combination of these flags describes the configuration state > of the edge detector, so formalize and clarify that by combining > them into a single variable, edflags, in struct line. > > The edflags is a subset of the GPIO_V2_LINE_FLAGsb relevant to
What is that "b" at the end of GPIO_V2_LINE_FLAGsb? Oh well no big deal. Bart can fix when applying if it is disturbing.
> the edge detector, and is also a superset of the eflags it replaces. > The eflags name is still used to describe the subset of edflags > corresponding to the rising/falling edge flags where edflags is > masked down to that subset. > > This consolidation reduces the number of variables being passed, > simplifies state comparisons, and provides a more extensible > foundation should additional edge sources be integrated in the > future. > > Signed-off-by: Kent Gibson <warthog618@gmail.com> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |