lkml.org 
[lkml]   [2022]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 18/19] arm64: dts: nuvoton: Add initial NPCM845 EVB device tree
On Sun, May 22, 2022 at 5:50 PM Tomer Maimon <tmaimon77@gmail.com> wrote:
> +/ {
> + model = "Nuvoton npcm845 Development Board (Device Tree)";
> + compatible = "nuvoton,npcm845";
> +
> + aliases {
> + serial0 = &serial0;
> + serial1 = &serial1;
> + serial2 = &serial2;
> + serial3 = &serial3;
> + };

> + apb {
> + serial0: serial@0 {
> + status = "okay";
> + };
> +
> + serial1: serial@1000 {
> + status = "disabled";
> + };
> +
> + serial2: serial@2000 {
> + status = "disabled";
> + };
> +
> + serial3: serial@3000 {
> + status = "disabled";
> + };

Please drop the aliases for disabled uarts. It probably also makes
sense to have the status="disabled" properties in the .dtsi file and
only override them when you explicitly want to enable a uart for a
board.

Arnd

\
 
 \ /
  Last update: 2022-05-23 11:43    [W:0.292 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site