lkml.org 
[lkml]   [2022]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 10/19] reset: npcm: using syscon instead of device data
From
On 22/05/2022 17:50, Tomer Maimon wrote:
> Using syscon device tree property instead of
> device data to handle the NPCM GCR registers.

https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586

>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
> drivers/reset/reset-npcm.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/reset/reset-npcm.c b/drivers/reset/reset-npcm.c
> index 2ea4d3136e15..0c963b21eddc 100644
> --- a/drivers/reset/reset-npcm.c
> +++ b/drivers/reset/reset-npcm.c
> @@ -138,8 +138,7 @@ static int npcm_reset_xlate(struct reset_controller_dev *rcdev,
> }
>
> static const struct of_device_id npcm_rc_match[] = {
> - { .compatible = "nuvoton,npcm750-reset",
> - .data = (void *)"nuvoton,npcm750-gcr" },
> + { .compatible = "nuvoton,npcm750-reset"},
> { }
> };
>
> @@ -155,14 +154,10 @@ static int npcm_usb_reset(struct platform_device *pdev, struct npcm_rc_data *rc)
> u32 ipsrst1_bits = 0;
> u32 ipsrst2_bits = NPCM_IPSRST2_USB_HOST;
> u32 ipsrst3_bits = 0;
> - const char *gcr_dt;
>
> - gcr_dt = (const char *)
> - of_match_device(dev->driver->of_match_table, dev)->data;
> -
> - gcr_regmap = syscon_regmap_lookup_by_compatible(gcr_dt);
> + gcr_regmap = syscon_regmap_lookup_by_phandle(dev->of_node, "syscon");

I think this just broke all existing boards...

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-05-23 10:59    [W:1.106 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site