lkml.org 
[lkml]   [2022]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 04/19] tty: serial: 8250: Add NPCM845 UART support
From
On 23/05/2022 14:58, Tomer Maimon wrote:
> Hi Arnd,
>
> Thanks for your comment.
>
> On Mon, 23 May 2022 at 14:48, Arnd Bergmann <arnd@arndb.de
> <mailto:arnd@arndb.de>> wrote:
>
> On Sun, May 22, 2022 at 5:50 PM Tomer Maimon <tmaimon77@gmail.com
> <mailto:tmaimon77@gmail.com>> wrote:
> > +++ b/drivers/tty/serial/8250/8250_of.c
> > @@ -333,6 +333,7 @@ static const struct of_device_id
> of_platform_serial_table[] = {
> >         { .compatible = "ti,da830-uart", .data = (void
> *)PORT_DA830, },
> >         { .compatible = "nuvoton,wpcm450-uart", .data = (void
> *)PORT_NPCM, },
> >         { .compatible = "nuvoton,npcm750-uart", .data = (void
> *)PORT_NPCM, },
> > +       { .compatible = "nuvoton,npcm845-uart", .data = (void
> *)PORT_NPCM, },
> >         { /* end of list */ },
>
> If these are compatible devices, it's usually easier to claim
> compatibility with both the specific chip and the older model
> as a fallback, to avoid driver changes. This seems to apply to
> the timer and watchdog devices as well.
>
> Just to make sure, Do you mean claim in the device tree?
> like
>
> compatible = "nuvoton,npcm845-timer", "nuvoton,npcm-timer";

compatible = "nuvoton,npcm845-timer", "nuvoton,npcm750-timer"";


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-05-23 15:11    [W:0.059 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site