| Date | Wed, 11 May 2022 12:26:27 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 02/18] EDAC/amd64: Remove scrub rate control for Family 17h and later |
| |
On Mon, May 09, 2022 at 02:55:18PM +0000, Yazen Ghannam wrote: > @@ -251,6 +234,9 @@ static int set_scrub_rate(struct mem_ctl_info *mci, u32 bw) > struct amd64_pvt *pvt = mci->pvt_info; > u32 min_scrubrate = 0x5; > > + if (pvt->umc) > + return -EPERM;
Since this function is testing families, it might be more straightforward for the check to be:
if (pvt->fam >= 0x17)
> + > if (pvt->fam == 0xf) > min_scrubrate = 0x0;
-- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
|