Messages in this thread Patch in this message | | | Date | Wed, 18 May 2022 13:02:13 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 10/18] EDAC/amd64: Add read_mc_regs() into pvt->ops |
| |
On Mon, May 09, 2022 at 02:55:26PM +0000, Yazen Ghannam wrote: > @@ -3766,6 +3751,7 @@ static struct low_ops umc_ops = { > .read_base_mask = umc_read_base_mask, > .determine_memory_type = umc_determine_memory_type, > .determine_ecc_sym_sz = umc_determine_ecc_sym_sz, > + .read_mc_regs = umc_read_mc_regs, > }; > > /* Use Family 16h versions for defaults and adjust as needed below. */ > @@ -3777,6 +3763,7 @@ static struct low_ops dct_ops = { > .read_base_mask = dct_read_base_mask, > .determine_memory_type = dct_determine_memory_type, > .determine_ecc_sym_sz = dct_determine_ecc_sym_sz, > + .read_mc_regs = dct_read_mc_regs,
Aha, good, here you do that split I mentioned earlier.
> static int per_family_init(struct amd64_pvt *pvt) > @@ -3938,7 +3925,15 @@ static int hw_info_get(struct amd64_pvt *pvt) > if (ret) > return ret; > > - read_mc_regs(pvt); > + pvt->ops->read_mc_regs(pvt); > + > + pvt->ops->prep_chip_selects(pvt); > + > + pvt->ops->read_base_mask(pvt); > + > + pvt->ops->determine_memory_type(pvt); > + > + pvt->ops->determine_ecc_sym_sz(pvt); >
Yeah, no need for the spaces.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |