Messages in this thread | | | Date | Fri, 29 Apr 2022 11:28:52 +0200 | Subject | Re: [PATCH v3 4/4] hugetlb: Clean up hugetlb_cma_reserve | From | David Hildenbrand <> |
| |
On 13.04.22 05:29, Peng Liu wrote: > Use more generic functions to deal with issues related to online > nodes. The changes will make the code simplified. > > Signed-off-by: Peng Liu <liupeng256@huawei.com> > --- > mm/hugetlb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 2e4d8d9fb7c6..4c529774cc08 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -6953,7 +6953,7 @@ void __init hugetlb_cma_reserve(int order) > if (hugetlb_cma_size_in_node[nid] == 0) > continue; > > - if (!node_state(nid, N_ONLINE)) { > + if (!node_online(nid)) { > pr_warn("hugetlb_cma: invalid node %d specified\n", nid); > hugetlb_cma_size -= hugetlb_cma_size_in_node[nid]; > hugetlb_cma_size_in_node[nid] = 0; > @@ -6992,7 +6992,7 @@ void __init hugetlb_cma_reserve(int order) > } > > reserved = 0; > - for_each_node_state(nid, N_ONLINE) { > + for_each_online_node(nid) { > int res; > char name[CMA_MAX_NAME]; >
Reviewed-by: David Hildenbrand <david@redhat.com>
-- Thanks,
David / dhildenb
| |