Messages in this thread | | | Date | Thu, 14 Apr 2022 16:50:42 -0700 | Subject | Re: [PATCH v3 2/4] hugetlb: Fix hugepages_setup when deal with pernode | From | Mike Kravetz <> |
| |
On 4/12/22 20:29, Peng Liu wrote: > Hugepages can be specified to pernode since "hugetlbfs: extend > the definition of hugepages parameter to support node allocation", > but the following problem is observed. > > Confusing behavior is observed when both 1G and 2M hugepage is set > after "numa=off". > cmdline hugepage settings: > hugepagesz=1G hugepages=0:3,1:3 > hugepagesz=2M hugepages=0:1024,1:1024 > results: > HugeTLB registered 1.00 GiB page size, pre-allocated 0 pages > HugeTLB registered 2.00 MiB page size, pre-allocated 1024 pages > > Furthermore, confusing behavior can be also observed when an > invalid node behind a valid node. To fix this, never allocate any > typical hugepage when an invalid parameter is received. > > Fixes: b5389086ad7b ("hugetlbfs: extend the definition of hugepages parameter to support node allocation") > Signed-off-by: Peng Liu <liupeng256@huawei.com> > --- > mm/hugetlb.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+)
Thanks!
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com> -- Mike Kravetz
| |