Messages in this thread | | | Date | Thu, 14 Apr 2022 19:24:08 -0700 | From | Davidlohr Bueso <> | Subject | Re: [PATCH v3 3/4] hugetlb: Fix return value of __setup handlers |
| |
On Wed, 13 Apr 2022, Peng Liu wrote:
>When __setup() return '0', using invalid option values causes the >entire kernel boot option string to be reported as Unknown. Hugetlb >calls __setup() and will return '0' when set invalid parameter >string. > >The following phenomenon is observed: > cmdline: > hugepagesz=1Y hugepages=1 > dmesg: > HugeTLB: unsupported hugepagesz=1Y > HugeTLB: hugepages=1 does not follow a valid hugepagesz, ignoring > Unknown kernel command line parameters "hugepagesz=1Y hugepages=1" > >Since hugetlb will print warning/error information before return for >invalid parameter string, just use return '1' to avoid print again. > >Signed-off-by: Peng Liu <liupeng256@huawei.com> >Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com> >Reviewed-by: Muchun Song <songmuchun@bytedance.com> >Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
| |