Messages in this thread | | | Date | Thu, 14 Apr 2022 19:15:11 -0700 | From | Davidlohr Bueso <> | Subject | Re: [PATCH v3 4/4] hugetlb: Clean up hugetlb_cma_reserve |
| |
On Wed, 13 Apr 2022, Peng Liu wrote:
>Use more generic functions to deal with issues related to online >nodes. The changes will make the code simplified. > >Signed-off-by: Peng Liu <liupeng256@huawei.com> >Reviewed-by: Muchun Song <songmuchun@bytedance.com> >Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com> >Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
>--- > mm/hugetlb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/mm/hugetlb.c b/mm/hugetlb.c >index 2e4d8d9fb7c6..4c529774cc08 100644 >--- a/mm/hugetlb.c >+++ b/mm/hugetlb.c >@@ -6953,7 +6953,7 @@ void __init hugetlb_cma_reserve(int order) > if (hugetlb_cma_size_in_node[nid] == 0) > continue; > >- if (!node_state(nid, N_ONLINE)) { >+ if (!node_online(nid)) {
You could update mm/page_ext.c as well
> pr_warn("hugetlb_cma: invalid node %d specified\n", nid); > hugetlb_cma_size -= hugetlb_cma_size_in_node[nid]; > hugetlb_cma_size_in_node[nid] = 0; >@@ -6992,7 +6992,7 @@ void __init hugetlb_cma_reserve(int order) > } > > reserved = 0; >- for_each_node_state(nid, N_ONLINE) { >+ for_each_online_node(nid) {
... and arch/ia64/kernel/uncached.c for this.
| |