Messages in this thread | | | Date | Tue, 8 Nov 2022 19:29:56 -0800 | Subject | Re: [PATCH v2 09/14] platform/x86/intel/ifs: Use generic microcode headers and functions | From | Sohil Mehta <> |
| |
On 11/7/2022 2:53 PM, Jithu Joseph wrote: > Existing implementation (broken) of IFS used a header format (for IFS > test images) which was very similar to microcode format, but didn’t > accommodate extended signatures. This meant same IFS test image had to > be duplicated for different steppings and the validation code in the > driver was only looking at the primary header parameters. Going forward > IFS test image headers has been tweaked to become fully compatible with > microcode format. > > Newer IFS test image headers will use microcode_header_intel->hdrver = 2, > so as to distinguish it from microcode images and older IFS test images. > > In light of the above, use struct microcode_header_intel directly in > IFS driver instead of duplicating into a separate ifs_header structure. > Further use existing microcode_sanity_check() and find_matching_signature() > directly instead of implementing separate ones within the driver. > > More IFS specific checks will be added subsequently. > > Reviewed-by: Tony Luck <tony.luck@intel.com> > Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>
| |