lkml.org 
[lkml]   [2022]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 04/14] x86/microcode/intel: Expose find_matching_signature() for IFS
    On Mon, Nov 07, 2022 at 02:53:13PM -0800, Jithu Joseph wrote:
    > IFS uses 'scan test images' provided by Intel that can be regarded as

    Why is that in '' quotes?

    > firmware. IFS test image carries microcode header with extended signature
    > table.
    >
    > Expose find_matching_signature() for verifying if the test image

    Yeah, not "expose" but "reuse".

    > header or the extended signature table indicate whether an IFS test image
    > is fit to run on a system.

    > Move the function to cpu/intel.c and
    > add intel_ prefix to the function name.

    That is not needed in a commit message - it is visible from the diff
    itself.

    Please remove the "what" in all your commit messages.

    ...

    --
    Regards/Gruss,
    Boris.

    https://people.kernel.org/tglx/notes-about-netiquette

    \
     
     \ /
      Last update: 2022-11-11 14:46    [W:4.261 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site