lkml.org 
[lkml]   [2022]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip: x86/microcode] x86/microcode/intel: Use appropriate type in microcode_sanity_check()
    The following commit has been merged into the x86/microcode branch of tip:

    Commit-ID: 2e13ab0158dd4a033d61a5baa8f9b5b7c9ea8431
    Gitweb: https://git.kernel.org/tip/2e13ab0158dd4a033d61a5baa8f9b5b7c9ea8431
    Author: Jithu Joseph <jithu.joseph@intel.com>
    AuthorDate: Wed, 16 Nov 2022 19:59:25 -08:00
    Committer: Borislav Petkov <bp@suse.de>
    CommitterDate: Fri, 18 Nov 2022 21:51:56 +01:00

    x86/microcode/intel: Use appropriate type in microcode_sanity_check()

    The data type of the @print_err parameter used by microcode_sanity_check()
    is int. In preparation for exporting this function to be used by
    the IFS driver convert it to a more appropriate bool type for readability.

    No functional change intended.

    Suggested-by: Tony Luck <tony.luck@intel.com>
    Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
    Signed-off-by: Borislav Petkov <bp@suse.de>
    Reviewed-by: Tony Luck <tony.luck@intel.com>
    Reviewed-by: Ashok Raj <ashok.raj@intel.com>
    Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>
    Link: https://lore.kernel.org/r/20221117035935.4136738-7-jithu.joseph@intel.com
    ---
    arch/x86/kernel/cpu/microcode/intel.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
    index c77ec1b..e48f05e 100644
    --- a/arch/x86/kernel/cpu/microcode/intel.c
    +++ b/arch/x86/kernel/cpu/microcode/intel.c
    @@ -135,7 +135,7 @@ static void save_microcode_patch(struct ucode_cpu_info *uci, void *data, unsigne
    intel_ucode_patch = p->data;
    }

    -static int microcode_sanity_check(void *mc, int print_err)
    +static int microcode_sanity_check(void *mc, bool print_err)
    {
    unsigned long total_size, data_size, ext_table_size;
    struct microcode_header_intel *mc_header = mc;
    @@ -253,7 +253,7 @@ scan_microcode(void *data, size_t size, struct ucode_cpu_info *uci, bool save)
    mc_size = get_totalsize(mc_header);
    if (!mc_size ||
    mc_size > size ||
    - microcode_sanity_check(data, 0) < 0)
    + microcode_sanity_check(data, false) < 0)
    break;

    size -= mc_size;
    @@ -792,7 +792,7 @@ static enum ucode_state generic_load_microcode(int cpu, struct iov_iter *iter)
    memcpy(mc, &mc_header, sizeof(mc_header));
    data = mc + sizeof(mc_header);
    if (!copy_from_iter_full(data, data_size, iter) ||
    - microcode_sanity_check(mc, 1) < 0) {
    + microcode_sanity_check(mc, true) < 0) {
    break;
    }

    \
     
     \ /
      Last update: 2022-11-19 17:26    [W:4.276 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site