lkml.org 
[lkml]   [2022]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip: x86/microcode] platform/x86/intel/ifs: Return a more appropriate error code
    The following commit has been merged into the x86/microcode branch of tip:

    Commit-ID: f4e209e956b5d66f0e6e34e89f19811c2c1e596e
    Gitweb: https://git.kernel.org/tip/f4e209e956b5d66f0e6e34e89f19811c2c1e596e
    Author: Jithu Joseph <jithu.joseph@intel.com>
    AuthorDate: Wed, 16 Nov 2022 19:59:21 -08:00
    Committer: Borislav Petkov <bp@suse.de>
    CommitterDate: Fri, 18 Nov 2022 21:30:36 +01:00

    platform/x86/intel/ifs: Return a more appropriate error code

    scan_chunks_sanity_check() returns -ENOMEM if it encounters an error
    while copying IFS test image from memory to Secure Memory.

    Return -EIO in this scenario, as it is more appropriate.

    Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
    Signed-off-by: Borislav Petkov <bp@suse.de>
    Reviewed-by: Tony Luck <tony.luck@intel.com>
    Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>
    Reviewed-by: Hans de Goede <hdegoede@redhat.com>
    Link: https://lore.kernel.org/r/20221117035935.4136738-3-jithu.joseph@intel.com
    ---
    drivers/platform/x86/intel/ifs/load.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/platform/x86/intel/ifs/load.c b/drivers/platform/x86/intel/ifs/load.c
    index d056617..89ce265 100644
    --- a/drivers/platform/x86/intel/ifs/load.c
    +++ b/drivers/platform/x86/intel/ifs/load.c
    @@ -157,8 +157,10 @@ static int scan_chunks_sanity_check(struct device *dev)
    INIT_WORK(&local_work.w, copy_hashes_authenticate_chunks);
    schedule_work_on(cpu, &local_work.w);
    wait_for_completion(&ifs_done);
    - if (ifsd->loading_error)
    + if (ifsd->loading_error) {
    + ret = -EIO;
    goto out;
    + }
    package_authenticated[curr_pkg] = 1;
    }
    ret = 0;
    \
     
     \ /
      Last update: 2022-11-19 17:26    [W:4.155 / U:0.572 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site