| Date | Mon, 7 Nov 2022 09:31:55 -0800 | Subject | Re: [PATCH v2 06/23] arm64: dts: Update cache properties for broadcom | From | Florian Fainelli <> |
| |
(way too many recipients, gmail's SMTP server would not allow me to respond unless I moved most people to BCC now done).
On 11/7/22 07:56, Pierre Gondois wrote: > The DeviceTree Specification v0.3 specifies that the cache node > 'compatible' and 'cache-level' properties are 'required'. Cf. > s3.8 Multi-level and Shared Cache Nodes > The 'cache-unified' property should be present if one of the > properties for unified cache is present ('cache-size', ...). > > Update the Device Trees accordingly. > > Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> > Acked-by: William Zhang <william.zhang@broadcom.com>
This looks fine, but incomplete, you seem to have missed:
- adding 'cache-unified' to all of the cache nodes modified in this patch set that did not have one already
- bcm63148.dtsi, bcm63178.dtsi, bcm6756.dtsi, bcm6846.dtsi, bcm6855.dtsi, bcm6878.dtsi, bcm47622.dtsi
Thanks -- Florian
|