Messages in this thread | | | Date | Mon, 21 Nov 2022 11:14:12 +0100 | Subject | Re: [PATCH v1 3/4] soc: starfive: Add StarFive JH71XX pmu driver | From | Krzysztof Kozlowski <> |
| |
On 18/11/2022 14:32, Walker Chen wrote: > Add generic power domain driver for the StarFive JH71XX SoC. > > Signed-off-by: Walker Chen <walker.chen@starfivetech.com>
Thank you for your patch. There is something to discuss/improve.
> + > +MODULE_AUTHOR("Walker Chen <walker.chen@starfivetech.com>"); > +MODULE_DESCRIPTION("StarFive JH71XX Power Domain Driver"); > +MODULE_LICENSE("GPL"); > diff --git a/include/soc/starfive/pm_domains.h b/include/soc/starfive/pm_domains.h > new file mode 100644 > index 000000000000..a20e28e9baf3 > --- /dev/null > +++ b/include/soc/starfive/pm_domains.h > @@ -0,0 +1,15 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (C) 2022 StarFive Technology Co., Ltd. > + * Author: Walker Chen <walker.chen@starfivetech.com> > + */ > + > +#ifndef __SOC_STARFIVE_PMDOMAINS_H__ > +#define __SOC_STARFIVE_PMDOMAINS_H__ > + > +#include <linux/types.h> > + > +void starfive_pmu_hw_event_turn_on(u32 mask); > +void starfive_pmu_hw_event_turn_off(u32 mask);
These are not used outside of driver. Drop entire header file.
Best regards, Krzysztof
| |