Messages in this thread | | | Date | Tue, 22 Nov 2022 15:46:34 +0800 | From | Walker Chen <> | Subject | Re: [PATCH v1 1/4] dt-bindings: power: Add StarFive JH7110 power domain definitions |
| |
On 2022/11/21 18:12, Krzysztof Kozlowski wrote: > On 18/11/2022 14:32, Walker Chen wrote: >> Add power domain definitions for the StarFive JH7110 SoC. >> >> Signed-off-by: Walker Chen <walker.chen@starfivetech.com> >> --- >> include/dt-bindings/power/jh7110-power.h | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> create mode 100644 include/dt-bindings/power/jh7110-power.h >> >> diff --git a/include/dt-bindings/power/jh7110-power.h b/include/dt-bindings/power/jh7110-power.h >> new file mode 100644 >> index 000000000000..24160c46fbaf >> --- /dev/null >> +++ b/include/dt-bindings/power/jh7110-power.h > > Filename matching compatible or bindings file.
So the file name should be changed to "starfive,jh7110-power.h" and the compatible in the driver should also be changed to "starfive,jh7110-power". Is it right ?
> >> @@ -0,0 +1,18 @@ >> +/* SPDX-License-Identifier: (GPL-2.0) */ > > Dual license for bindings.
Ok, the license will be changed to GPL-2.0 or MIT in the patch v2.
> >> +/* >> + * Copyright (C) 2022 StarFive Technology Co., Ltd. >> + * Author: Walker Chen <walker.chen@starfivetech.com> >> + */ >> +#ifndef __DT_BINDINGS_POWER_JH7110_POWER_H__ >> +#define __DT_BINDINGS_POWER_JH7110_POWER_H__ > > Best regards, > Krzysztof >
| |