| Date | Mon, 24 Jan 2022 09:05:05 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH 41/54] arch/x86: replace cpumask_weight with cpumask_weight_eq where appropriate |
| |
On Sun, Jan 23, 2022 at 10:39:12AM -0800, Yury Norov wrote: > smpboot code in somw places calls cpumask_weight() to compare the weight > of cpumask with a given number. We can do it more efficiently with > cpumask_weight_eq() because conditional cpumask_weight may stop traversing > the cpumask earlier, as soon as condition is met.
Why use a more complicated API for code that has no performance requirements?
From where I'm sitting this is a net negative for making the code harder to read.
|