lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 27/54] lib/bitmap: add bitmap_weight_{cmp, eq, gt, ge, lt, le} functions
On Mon, Jan 24, 2022 at 02:41:38PM +0200, Andy Shevchenko wrote:
> On Sun, Jan 23, 2022 at 10:38:58AM -0800, Yury Norov wrote:

...

> > + if (num > (int)nbits || num < 0)
>
> Wonder if
>
> if (abs(num) > nbits)
>
> would be sufficient.

Scratch it. Of course it won't work.

It may be other way around:

if ((unsigned int)num > nbits)

> > + return -num;

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2022-01-24 13:45    [W:0.093 / U:0.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site