| Date | Mon, 24 Jan 2022 14:48:12 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH 33/54] net: ethernet: replace bitmap_weight with bitmap_weight_{eq,gt,ge,lt,le} for mellanox |
| |
On Sun, Jan 23, 2022 at 10:39:04AM -0800, Yury Norov wrote: > Mellanox code uses bitmap_weight() to compare the weight of bitmap with > a given number. We can do it more efficiently with bitmap_weight_{eq, ...} > because conditional bitmap_weight may stop traversing the bitmap earlier, > as soon as condition is met.
> - if (port <= 0 || port > m) > + if (port <= 0 || bitmap_weight_lt(actv_ports.ports, dev->caps.num_ports, port)) > return -EINVAL;
Can we eliminate now the port <= 0 check? Or at least make it port == 0?
-- With Best Regards, Andy Shevchenko
|