lkml.org 
[lkml]   [2022]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/54] net/dsa: don't use bitmap_weight() in b53_arl_read()
    Date
    Don't call bitmap_weight() if the following code can get by
    without it.

    Signed-off-by: Yury Norov <yury.norov@gmail.com>
    ---
    drivers/net/dsa/b53/b53_common.c | 6 +-----
    1 file changed, 1 insertion(+), 5 deletions(-)

    diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c
    index 3867f3d4545f..9a10d80125d9 100644
    --- a/drivers/net/dsa/b53/b53_common.c
    +++ b/drivers/net/dsa/b53/b53_common.c
    @@ -1620,12 +1620,8 @@ static int b53_arl_read(struct b53_device *dev, u64 mac,
    return 0;
    }

    - if (bitmap_weight(free_bins, dev->num_arl_bins) == 0)
    - return -ENOSPC;
    -
    *idx = find_first_bit(free_bins, dev->num_arl_bins);
    -
    - return -ENOENT;
    + return *idx >= dev->num_arl_bins ? -ENOSPC : -ENOENT;
    }

    static int b53_arl_op(struct b53_device *dev, int op, int port,
    --
    2.30.2
    \
     
     \ /
      Last update: 2022-01-23 19:41    [W:4.222 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site