lkml.org 
[lkml]   [2021]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v11 7/9] drivers: thermal: tsens: Drop unused define for msm8960
Date


On 3/18/21 8:52 PM, Ansuel Smith wrote:
> Drop unused define for msm8960 replaced by generic api and reg_field.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>

Thanks for the clean up!

Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org>

Warm Regards
Thara

> ---
> drivers/thermal/qcom/tsens-8960.c | 24 +-----------------------
> 1 file changed, 1 insertion(+), 23 deletions(-)
>
> diff --git a/drivers/thermal/qcom/tsens-8960.c b/drivers/thermal/qcom/tsens-8960.c
> index 8c523b764862..31e44d17d484 100644
> --- a/drivers/thermal/qcom/tsens-8960.c
> +++ b/drivers/thermal/qcom/tsens-8960.c
> @@ -10,8 +10,6 @@
> #include <linux/thermal.h>
> #include "tsens.h"
>
> -#define CAL_MDEGC 30000
> -
> #define CONFIG_ADDR 0x3640
> #define CONFIG_ADDR_8660 0x3620
> /* CONFIG_ADDR bitmasks */
> @@ -21,39 +19,19 @@
> #define CONFIG_SHIFT_8660 28
> #define CONFIG_MASK_8660 (3 << CONFIG_SHIFT_8660)
>
> -#define STATUS_CNTL_ADDR_8064 0x3660
> #define CNTL_ADDR 0x3620
> /* CNTL_ADDR bitmasks */
> #define EN BIT(0)
> #define SW_RST BIT(1)
> -#define SENSOR0_EN BIT(3)
> +
> #define MEASURE_PERIOD BIT(18)
> #define SLP_CLK_ENA BIT(26)
> #define SLP_CLK_ENA_8660 BIT(24)
> #define SENSOR0_SHIFT 3
>
> -/* INT_STATUS_ADDR bitmasks */
> -#define MIN_STATUS_MASK BIT(0)
> -#define LOWER_STATUS_CLR BIT(1)
> -#define UPPER_STATUS_CLR BIT(2)
> -#define MAX_STATUS_MASK BIT(3)
> -
> #define THRESHOLD_ADDR 0x3624
> -/* THRESHOLD_ADDR bitmasks */
> -#define THRESHOLD_MAX_LIMIT_SHIFT 24
> -#define THRESHOLD_MIN_LIMIT_SHIFT 16
> -#define THRESHOLD_UPPER_LIMIT_SHIFT 8
> -#define THRESHOLD_LOWER_LIMIT_SHIFT 0
> -
> -/* Initial temperature threshold values */
> -#define LOWER_LIMIT_TH 0x50
> -#define UPPER_LIMIT_TH 0xdf
> -#define MIN_LIMIT_TH 0x0
> -#define MAX_LIMIT_TH 0xff
>
> #define INT_STATUS_ADDR 0x363c
> -#define TRDY_MASK BIT(7)
> -#define TIMEOUT_US 100
>
> #define S0_STATUS_OFF 0x3628
> #define S1_STATUS_OFF 0x362c
>

--
Warm Regards
Thara

\
 
 \ /
  Last update: 2021-03-19 14:13    [W:0.128 / U:2.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site