Messages in this thread | | | Date | Sun, 24 Oct 2021 17:31:00 +0200 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH 03/15] irq: mips: simplify do_domain_IRQ() |
| |
On Thu, Oct 21, 2021 at 07:02:24PM +0100, Mark Rutland wrote: > There's no need fpr arch/mips's do_domain_IRQ() to open-code the NULL > check performed by handle_irq_desc(), nor the resolution of the desc > performed by generic_handle_domain_irq(). > > Use generic_handle_domain_irq() directly, as this is functioanlly > equivalent and clearer. > > There should be no functional change as a result of this patch. > > Signed-off-by: Mark Rutland <mark.rutland@arm.com> > Cc: Marc Zyngier <maz@kernel.org> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > Cc: Thomas Gleixner <tglx@linutronix.de> > --- > arch/mips/kernel/irq.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c > index d20e002b3246..1fee96ef8059 100644 > --- a/arch/mips/kernel/irq.c > +++ b/arch/mips/kernel/irq.c > @@ -115,11 +115,7 @@ void __irq_entry do_domain_IRQ(struct irq_domain *domain, unsigned int hwirq) > > irq_enter(); > check_stack_overflow(); > - > - desc = irq_resolve_mapping(domain, hwirq); > - if (likely(desc)) > - handle_irq_desc(desc); > - > + generic_handle_domain_irq(domain, hwirq); > irq_exit(); > } > #endif > -- > 2.11.0
Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
| |