Messages in this thread | | | Date | Fri, 22 Oct 2021 16:36:02 +0100 | From | Mark Rutland <> | Subject | Re: [PATCH 09/15] irq: arm: perform irqentry in entry code |
| |
On Fri, Oct 22, 2021 at 04:18:18PM +0100, Vladimir Murzin wrote: > Hi Mark, > > On 10/21/21 7:02 PM, Mark Rutland wrote: > > +/* > > + * TODO: restructure the ARMv7M entry logic so that this entry logic can live > > + * in arch code. > > + */ > > +asmlinkage void __exception_irq_entry > > +static void nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs) > > I'm seeing build time failure... > > drivers/irqchip/irq-nvic.c:50:8: error: two or more data types in declaration specifiers > static void nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs) > ^~~~ > drivers/irqchip/irq-nvic.c:50:13: warning: 'nvic_handle_irq' defined but not used [-Wunused-function] > static void nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs) > > I've fixed that locally and planing to give it a go...
Ah, whoops. I've removed the extraneous `static void` from nvic_handle_irq() and build tested that as part of stm32_defconfig.
The updated version is in my irq/handle-domain-irq branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git
Thanks, Mark.
| |