Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 21 Jan 2021 11:58:42 +0100 | Subject | Re: [PATCH] PM / clk: make PM clock layer compatible with clocks that must sleep |
| |
On Thu, Jan 21, 2021 at 10:13 AM Naresh Kamboju <naresh.kamboju@linaro.org> wrote: > On Tue, 5 Jan 2021 at 08:48, Nicolas Pitre <npitre@baylibre.com> wrote: > > > > The clock API splits its interface into sleepable ant atomic contexts: > > > > - clk_prepare/clk_unprepare for stuff that might sleep > > > > - clk_enable_clk_disable for anything that may be done in atomic context > > > > <trim> > > > > > Signed-off-by: Nicolas Pitre <npitre@baylibre.com> > > > > diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c > > index ced6863a16..a62fb0f9b1 100644 > > --- a/drivers/base/power/clock_ops.c > > +++ b/drivers/base/power/clock_ops.c > > <trim> > > > @@ -64,17 +166,20 @@ static void pm_clk_acquire(struct device *dev, struct pm_clock_entry *ce) > > ce->clk = clk_get(dev, ce->con_id); > > if (IS_ERR(ce->clk)) { > > ce->status = PCE_STATUS_ERROR; > > + return; > > + } else if (clk_is_enabled_when_prepared(ce->clk)) { > > arm-linux-gnueabihf-ld: drivers/base/power/clock_ops.o: in function > `pm_clk_acquire': > drivers/base/power/clock_ops.c:170: undefined reference to > `clk_is_enabled_when_prepared' > > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > > This build error was noticed on arm architecture on linux next 20210121 tag. > Following builds failed. > - arm (omap1_defconfig) with clang-10 - FAILED > - arm (omap1_defconfig) with clang-11 - FAILED > > - arm (omap1_defconfig) with gcc-8 - FAILED > - arm (omap1_defconfig) with gcc-9 - FAILED > - arm (omap1_defconfig) with gcc-10 - FAILED
Missing dummy clk_is_enabled_when_prepared() for the !CONFIG_HAVE_CLK case?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |