Messages in this thread | | | From | Naresh Kamboju <> | Date | Thu, 21 Jan 2021 14:41:02 +0530 | Subject | Re: [PATCH] PM / clk: make PM clock layer compatible with clocks that must sleep |
| |
Hi Nicolas,
On Tue, 5 Jan 2021 at 08:48, Nicolas Pitre <npitre@baylibre.com> wrote: > > The clock API splits its interface into sleepable ant atomic contexts: > > - clk_prepare/clk_unprepare for stuff that might sleep > > - clk_enable_clk_disable for anything that may be done in atomic context >
<trim>
> > Signed-off-by: Nicolas Pitre <npitre@baylibre.com> > > diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c > index ced6863a16..a62fb0f9b1 100644 > --- a/drivers/base/power/clock_ops.c > +++ b/drivers/base/power/clock_ops.c
<trim>
> @@ -64,17 +166,20 @@ static void pm_clk_acquire(struct device *dev, struct pm_clock_entry *ce) > ce->clk = clk_get(dev, ce->con_id); > if (IS_ERR(ce->clk)) { > ce->status = PCE_STATUS_ERROR; > + return; > + } else if (clk_is_enabled_when_prepared(ce->clk)) {
arm-linux-gnueabihf-ld: drivers/base/power/clock_ops.o: in function `pm_clk_acquire': drivers/base/power/clock_ops.c:170: undefined reference to `clk_is_enabled_when_prepared'
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
This build error was noticed on arm architecture on linux next 20210121 tag. Following builds failed. - arm (omap1_defconfig) with clang-10 - FAILED - arm (omap1_defconfig) with clang-11 - FAILED
- arm (omap1_defconfig) with gcc-8 - FAILED - arm (omap1_defconfig) with gcc-9 - FAILED - arm (omap1_defconfig) with gcc-10 - FAILED
Steps to reproduce: --------------------------- 1)
# TuxMake is a command line tool and Python library that provides # portable and repeatable Linux kernel builds across a variety of # architectures, toolchains, kernel configurations, and make targets. # # TuxMake supports the concept of runtimes. # See https://docs.tuxmake.org/runtimes/, for that to work it requires # that you install podman or docker on your system. # # To install tuxmake on your system globally: # sudo pip3 install -U tuxmake # # See https://docs.tuxmake.org/ for complete documentation.
tuxmake --runtime docker --target-arch arm --toolchain gcc-8 --kconfig omap1_defconfig
2) tuxbuild build --git-repo https://gitlab.com/Linaro/lkft/mirrors/next/linux-next --git-sha bc085f8fc88fc16796c9f2364e2bfb3fef305cad --target-arch arm --toolchain gcc-8 --kconfig omap1_defconfig
-- Linaro LKFT https://lkft.linaro.org
| |