Messages in this thread | | | From | Naresh Kamboju <> | Date | Thu, 21 Jan 2021 17:39:39 +0530 | Subject | Re: [PATCH] PM / clk: make PM clock layer compatible with clocks that must sleep |
| |
On Thu, 21 Jan 2021 at 16:28, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Thu, Jan 21, 2021 at 10:13 AM Naresh Kamboju > <naresh.kamboju@linaro.org> wrote: > > On Tue, 5 Jan 2021 at 08:48, Nicolas Pitre <npitre@baylibre.com> wrote: > > > > > > The clock API splits its interface into sleepable ant atomic contexts: > > > > > > - clk_prepare/clk_unprepare for stuff that might sleep > > > > > > - clk_enable_clk_disable for anything that may be done in atomic context > > > > > > > <trim> > > > > > > > > Signed-off-by: Nicolas Pitre <npitre@baylibre.com> > > > > > > diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c > > > index ced6863a16..a62fb0f9b1 100644 > > > --- a/drivers/base/power/clock_ops.c > > > +++ b/drivers/base/power/clock_ops.c > > > > <trim> > > > > > @@ -64,17 +166,20 @@ static void pm_clk_acquire(struct device *dev, struct pm_clock_entry *ce) > > > ce->clk = clk_get(dev, ce->con_id); > > > if (IS_ERR(ce->clk)) { > > > ce->status = PCE_STATUS_ERROR; > > > + return; > > > + } else if (clk_is_enabled_when_prepared(ce->clk)) { > > > > arm-linux-gnueabihf-ld: drivers/base/power/clock_ops.o: in function > > `pm_clk_acquire': > > drivers/base/power/clock_ops.c:170: undefined reference to > > `clk_is_enabled_when_prepared' > > > > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > > > > This build error was noticed on arm architecture on linux next 20210121 tag. > > Following builds failed. > > - arm (omap1_defconfig) with clang-10 - FAILED > > - arm (omap1_defconfig) with clang-11 - FAILED > > > > - arm (omap1_defconfig) with gcc-8 - FAILED > > - arm (omap1_defconfig) with gcc-9 - FAILED > > - arm (omap1_defconfig) with gcc-10 - FAILED > > Missing dummy clk_is_enabled_when_prepared() for the > !CONFIG_HAVE_CLK case?
I see these configs enabled in failed builds config file,
CONFIG_HAVE_CLK=y CONFIG_CLKDEV_LOOKUP=y CONFIG_HAVE_LEGACY_CLK=y
ref: https://builds.tuxbuild.com/1nN0vkpNP4qhvIuIJN12j7tTpQs/
- Naresh
| |