Messages in this thread | | | Subject | Re: [PATCH 6/9] nfsd: fix empty-body warning in nfs4state.c | From | Sergei Shtylyov <> | Date | Sun, 19 Apr 2020 12:32:08 +0300 |
| |
Hello!
On 18.04.2020 21:41, Randy Dunlap wrote:
> Fix gcc empty-body warning when -Wextra is used: > > ../fs/nfsd/nfs4state.c:3898:3: warning: suggest braces around empty body in an ‘else’ statement [-Wempty-body] > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Linus Torvalds <torvalds@linux-foundation.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: "J. Bruce Fields" <bfields@fieldses.org> > Cc: Chuck Lever <chuck.lever@oracle.com> > Cc: linux-nfs@vger.kernel.org > --- > fs/nfsd/nfs4state.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- linux-next-20200417.orig/fs/nfsd/nfs4state.c > +++ linux-next-20200417/fs/nfsd/nfs4state.c [...] > @@ -3895,7 +3896,7 @@ nfsd4_setclientid(struct svc_rqst *rqstp > copy_clid(new, conf); > gen_confirm(new, nn); > } else /* case 4 (new client) or cases 2, 3 (client reboot): */ > - ; > + do_empty();
In this case explicit {} would probably have been better, as described in Documentation/process/coding-style.rst, clause (3).
MBR, Sergei
| |