Messages in this thread | | | Date | Sat, 18 Apr 2020 11:44:09 -0700 | From | Matthew Wilcox <> | Subject | Re: [PATCH 5/9] usb: fix empty-body warning in sysfs.c |
| |
On Sat, Apr 18, 2020 at 11:41:07AM -0700, Randy Dunlap wrote: > +++ linux-next-20200327/drivers/usb/core/sysfs.c > @@ -1263,7 +1263,7 @@ void usb_create_sysfs_intf_files(struct > if (!alt->string && !(udev->quirks & USB_QUIRK_CONFIG_INTF_STRINGS)) > alt->string = usb_cache_string(udev, alt->desc.iInterface); > if (alt->string && device_create_file(&intf->dev, &dev_attr_interface)) > - ; /* We don't actually care if the function fails. */ > + do_empty(); /* We don't actually care if the function fails. */ > intf->sysfs_files_created = 1; > }
Why not just?
+ if (alt->string) + device_create_file(&intf->dev, &dev_attr_interface);
| |