lkml.org 
[lkml]   [2020]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/9] fix empty-body warning in posix_acl.c
From
Date

> On Apr 18, 2020, at 1:53 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> Thirdly, there's a *reason* why "-Wextra" isn't used.
>
> The warnings enabled by -Wextra are usually complete garbage, and
> trying to fix them often makes the code worse. Exactly like here.
>

As the instigator of this warning cleanup activity, even _I_ don’t recommend
building with all of -Wextra. Doing so on an allmodconfig build generates
500 megabytes of warning text (not exaggerating), primarily due to
-Wunused-parameter and Wmissing-field-initializers.

I strongly recommend disabling them with -Wno-unused-parameter
-Wno-missing-field-initializers since the spew is completely unactionable.

On the other hand, -Woverride-init found a legit bug that was breaking DVD
drives, fixed in commit 03264ddde2453f6877a7d637d84068079632a3c5.

I believe finding a good set of compiler warning settings can lead to lots of
good bugs being spotted and (hopefully) fixed. Why let syzbot do all the work?

zzy

\
 
 \ /
  Last update: 2020-04-20 21:59    [W:0.060 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site