Messages in this thread | | | Subject | Re: [RFC PATCH 1/9] kernel.h: add do_empty() macro | From | Randy Dunlap <> | Date | Sat, 18 Apr 2020 11:49:58 -0700 |
| |
On 4/18/20 11:44 AM, Joe Perches wrote: > On Sat, 2020-04-18 at 11:41 -0700, Randy Dunlap wrote: >> Add the do_empty() macro to silence gcc warnings about an empty body >> following an "if" statement when -Wextra is used. >> >> However, for debug printk calls that are being disabled, use either >> no_printk() or pr_debug() [and optionally dynamic printk debugging] >> instead. > [] >> +#define do_empty() do { } while (0) > > If this is really useful > (I think the warning is somewhat silly) > > bikeshed: > > I think do_nothing() is more descriptive
Yes, I do too, as I more or less mentioned in the cover letter.
-- ~Randy
| |