| Subject | Re: [PATCH 38/41] scsi: sym53c8xx_2: sym_hipd: mark expected switch fall-throughs | From | "Gustavo A. R. Silva" <> | Date | Wed, 19 Dec 2018 18:08:18 -0600 |
| |
Hi,
Friendly ping:
Who can ack or review this patch, please?
Thanks -- Gustavo
On 11/27/18 10:34 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 114996 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/scsi/sym53c8xx_2/sym_hipd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/sym53c8xx_2/sym_hipd.c b/drivers/scsi/sym53c8xx_2/sym_hipd.c > index 0a2a54517b15..054fb0599263 100644 > --- a/drivers/scsi/sym53c8xx_2/sym_hipd.c > +++ b/drivers/scsi/sym53c8xx_2/sym_hipd.c > @@ -3072,6 +3072,7 @@ static void sym_sir_bad_scsi_status(struct sym_hcb *np, int num, struct sym_ccb > sym_print_addr(cp->cmd, "%s\n", > s_status == S_BUSY ? "BUSY" : "QUEUE FULL\n"); > } > + /* fall through */ > default: /* S_INT, S_INT_COND_MET, S_CONFLICT */ > sym_complete_error (np, cp); > break; > @@ -4632,6 +4633,7 @@ static void sym_int_sir(struct sym_hcb *np) > * Negotiation failed. > * Target does not want answer message. > */ > + /* fall through */ > case SIR_NEGO_PROTO: > sym_nego_default(np, tp, cp); > goto out; >
|