Messages in this thread | | | Subject | Re: [PATCH 10/41] scsi: bfa: bfa_fcs_lport: Mark expected switch fall-throughs | From | "Gustavo A. R. Silva" <> | Date | Thu, 10 Jan 2019 14:12:20 -0600 |
| |
Hi,
Friendly ping (second one):
Who can ack/review/take this patch, please?
Thanks -- Gustavo
On 12/19/18 9:39 AM, Gustavo A. R. Silva wrote: > Hi, > > Friendly ping: > > Who can ack or review this patch, please? > > Thanks > -- > Gustavo > > On 11/27/18 10:27 PM, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> Notice that, in this particular case, I replaced "!!! fall through !!!" >> with a "fall through" annotation, which is what GCC is expecting to >> find. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> --- >> drivers/scsi/bfa/bfa_fcs_lport.c | 8 ++------ >> 1 file changed, 2 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/scsi/bfa/bfa_fcs_lport.c b/drivers/scsi/bfa/bfa_fcs_lport.c >> index b4f2c1d8742e..646f09f66443 100644 >> --- a/drivers/scsi/bfa/bfa_fcs_lport.c >> +++ b/drivers/scsi/bfa/bfa_fcs_lport.c >> @@ -6430,9 +6430,7 @@ bfa_fcs_vport_sm_logo_for_stop(struct bfa_fcs_vport_s *vport, >> switch (event) { >> case BFA_FCS_VPORT_SM_OFFLINE: >> bfa_sm_send_event(vport->lps, BFA_LPS_SM_OFFLINE); >> - /* >> - * !!! fall through !!! >> - */ >> + /* fall through */ >> case BFA_FCS_VPORT_SM_RSP_OK: >> case BFA_FCS_VPORT_SM_RSP_ERROR: >> @@ -6458,9 +6456,7 @@ bfa_fcs_vport_sm_logo(struct bfa_fcs_vport_s *vport, >> switch (event) { >> case BFA_FCS_VPORT_SM_OFFLINE: >> bfa_sm_send_event(vport->lps, BFA_LPS_SM_OFFLINE); >> - /* >> - * !!! fall through !!! >> - */ >> + /* fall through */ >> case BFA_FCS_VPORT_SM_RSP_OK: >> case BFA_FCS_VPORT_SM_RSP_ERROR: >>
| |