| Subject | Re: [PATCH 35/41] scsi: ppa: mark expected switch fall-through | From | "Gustavo A. R. Silva" <> | Date | Wed, 19 Dec 2018 18:07:48 -0600 |
| |
Hi,
Friendly ping:
Who can ack or review this patch, please?
Thanks -- Gustavo
On 11/27/18 10:33 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 114988 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/scsi/ppa.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/ppa.c b/drivers/scsi/ppa.c > index ee86a0c62dbf..d29999ba5458 100644 > --- a/drivers/scsi/ppa.c > +++ b/drivers/scsi/ppa.c > @@ -717,6 +717,7 @@ static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd) > } > cmd->SCp.phase++; > } > + /* fall through */ > > case 2: /* Phase 2 - We are now talking to the scsi bus */ > if (!ppa_select(dev, scmd_id(cmd))) { >
|