| Subject | Re: [PATCH 31/41] scsi: mpt3sas: mpt3sas_scsih: Mark expected switch fall-through | From | "Gustavo A. R. Silva" <> | Date | Wed, 19 Dec 2018 18:07:00 -0600 |
| |
Hi,
Friendly ping:
Who can ack or review this patch, please?
Thanks -- Gustavo
On 11/27/18 10:32 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1475400 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/scsi/mpt3sas/mpt3sas_scsih.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > index 5b9806d0719e..920b80ce4748 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > @@ -10370,6 +10370,7 @@ _scsih_probe(struct pci_dev *pdev, const struct pci_device_id *id) > case MPI26_MFGPAGE_DEVID_CFG_SEC_3916: > dev_info(&pdev->dev, > "HBA is in Configurable Secure mode\n"); > + /* fall through */ > case MPI26_MFGPAGE_DEVID_SAS3508: > case MPI26_MFGPAGE_DEVID_SAS3508_1: > case MPI26_MFGPAGE_DEVID_SAS3408: >
|