Messages in this thread | | | Date | Mon, 17 Dec 2018 10:24:15 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH v3 2/6] irqchip: sifive-plic: Add struct plic_hw for global PLIC HW details |
| |
> +struct plic_hw { > + u32 nr_irqs; > + u32 nr_handlers; > + u32 nr_mapped; > + void __iomem *regs; > + struct irq_domain *irqdomain; > +}; > + > +static struct plic_hw plic;
Please use local variables instead of a single instance struct. And only add these variables in the patches where you actually need them.
| |