Messages in this thread | | | From | Anup Patel <> | Date | Tue, 18 Dec 2018 13:55:00 +0530 | Subject | Re: [PATCH v3 2/6] irqchip: sifive-plic: Add struct plic_hw for global PLIC HW details |
| |
On Mon, Dec 17, 2018 at 11:54 PM Christoph Hellwig <hch@infradead.org> wrote: > > > +struct plic_hw { > > + u32 nr_irqs; > > + u32 nr_handlers; > > + u32 nr_mapped; > > + void __iomem *regs; > > + struct irq_domain *irqdomain; > > +}; > > + > > +static struct plic_hw plic; > > Please use local variables instead of a single instance struct. > And only add these variables in the patches where you actually need > them.
I am sure it will be useful in-future but for now I will remove the struct instance.
Regards, Anup
| |