Messages in this thread | | | Date | Wed, 19 Dec 2018 08:28:36 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH v3 3/6] irqchip: sifive-plic: More flexible plic_irq_toggle() |
| |
On Tue, Dec 18, 2018 at 02:20:10PM +0530, Anup Patel wrote: > Actually these functions should not be inline because plic_toggle() uses > raw_spin_lock() and plic_irq_toggle() uses for-loop.
So? It still inlines the all of two instances into each caller for slightly different but related work. Not sure it is 100% worth it, but probably more than the one to move the calculations to init time..
| |