[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCHSET block/for-4.2/writeback] block, cgroup: make cfq charge async IOs to the appropriate blkcgs
Tejun Heo <> writes:

> Hello,
> cfq has always charged all async IOs to the root cgroup. It didn't
> have much choice as writeback didn't know about cgroups and there was
> no way to tell who to blame for a given writeback IO. writeback
> finally grew support for cgroups and now tags each writeback IO with
> the appropriate cgroup to charge it against.
> This patchset updates cfq so that it follows the blkcg each bio is
> tagged with. Async cfq_queues are now shared across cfq_group, which
> is per-cgroup, instead of per-request_queue cfq_data. This makes all
> IOs follow the weight based IO resource distribution implemented by
> cfq.
> This patchset contains the following 8 patches.
> 0001-cfq-iosched-simplify-control-flow-in-cfq_get_queue.patch
> 0002-cfq-iosched-fix-async-oom-queue-handling.patch
> 0003-cfq-iosched-fix-oom-cfq_queue-ref-leak-in-cfq_set_re.patch
> 0004-cfq-iosched-minor-cleanups.patch
> 0005-cfq-iosched-remove-gfp_mask-from-cfq_find_alloc_queu.patch
> 0006-cfq-iosched-move-cfq_group-determination-from-cfq_fi.patch
> 0007-cfq-iosched-fold-cfq_find_alloc_queue-into-cfq_get_q.patch
> 0008-cfq-iosched-charge-async-IOs-to-the-appropriate-blkc.patch

Hi, Tejun,

Assuming you're ok with dropping patch 5, I'll review patches 6-8 once
they've been reworked to account for that. I took a look at them, and
they look OK to me. But, if they are going to change, I'd rather wait
to ack the final versions.


 \ /
  Last update: 2015-06-08 22:21    [W:0.094 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site