[lkml]   [2015]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCHSET block/for-4.2/writeback] block, cgroup: make cfq charge async IOs to the appropriate blkcgs
Tejun Heo <> writes:

> Hey, Jeff.
> On Mon, Jun 08, 2015 at 03:49:56PM -0400, Jeff Moyer wrote:
>> Assuming you're ok with dropping patch 5, I'll review patches 6-8 once
> I'll update it to use GPF_NOWAIT. Can't drop it easily as that would
> complicate group lookup more complicated w/ pinning and all.
>> they've been reworked to account for that. I took a look at them, and
>> they look OK to me. But, if they are going to change, I'd rather wait
>> to ack the final versions.
> Hmm... the changes will be simple s/GFP_ATOMIC/GFP_NOWAIT. Shouldn't
> affect reviewing, I think.

Yeah, I sent this email before realizing that GFP_NOWAIT would work out.
I've reviewed the rest of the series. Looks good to me! You did a nice
job splitting things up into easily reviewable pieces, so thanks for


 \ /
  Last update: 2015-06-09 17:21    [W:0.042 / U:2.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site