Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH 4/8] cfq-iosched: minor cleanups | Date | Mon, 08 Jun 2015 14:59:49 -0400 |
| |
Tejun Heo <tj@kernel.org> writes:
> * Some were accessing cic->cfqq[] directly. Always use cic_to_cfqq() > and cic_set_cfqq(). > > * check_ioprio_changed() doesn't need to verify cfq_get_queue()'s > return for NULL. It's always non-NULL. Simplify accordingly. > > This patch doesn't cause any functional changes. > > Signed-off-by: Tejun Heo <tj@kernel.org> > Cc: Vivek Goyal <vgoyal@redhat.com> > Cc: Arianna Avanzini <avanzini.arianna@gmail.com>
Looks good. I don't much like the "bool is_sync" function parameters. Calls to cic_to_cfqq, cic_set_cfqq, etc would be much easier to read if they took BLK_RW_SYNC and BLK_RW_ASYNC. Certainly not a problem with this patch, though, just a general observation.
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
| |