[lkml]   [2015]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 3/8] cfq-iosched: fix oom cfq_queue ref leak in cfq_set_request()
Tejun Heo <> writes:

> If the cfq_queue cached in cfq_io_cq is the oom one, cfq_set_request()
> replaces it by invoking cfq_get_queue() again without putting the oom
> queue leaking the reference it was holding. While oom queues are not
> released through reference counting, they're still reference counted
> and this can theoretically lead to the reference count overflowing and
> incorrectly invoke the usual release path on it.
> Fix it by making cfq_set_request() put the ref it was holding.
> Signed-off-by: Tejun Heo <>
> Cc: Vivek Goyal <>
> Cc: Arianna Avanzini <>

Reviewed-by: Jeff Moyer <>

 \ /
  Last update: 2015-06-08 21:01    [W:0.138 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site