Messages in this thread | | | From | John Youn <> | Subject | Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails | Date | Mon, 29 Jun 2015 23:59:42 +0000 |
| |
On 6/29/2015 2:48 PM, Felipe Balbi wrote: > Hi again, > > On Mon, Jun 29, 2015 at 04:47:01PM -0500, Felipe Balbi wrote: >> On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wrote: >>> We need to return error to caller if command is not sent to >>> controller succesfully. >>> >>> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com> >>> Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver) >>> Cc: <stable@vger.kernel.org> >>> --- >>> v2 changes: >>> Added Fixes and Cc in commit message. >> >> I noticed that this breaks at least my AM437x silicon with DWC3 2.40a >> when used with g_zero and testusb. As of now, it could be that silicon >> is mis-behaving because I got a Transfer Complete before the failing Set >> Endpoint Transfer Resource command. >> >> In any case, can you run on your setup with g_zero and test.sh/testusb >> [1]/[2] just to verify that it really works for you ? >> >> Meanwhile, I'll continue testing on my end. >> >> cheers >> >> [1] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c81374aafb795c6e40:testusb.c >> [2] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c81374aafb795c6e40:test.sh > > Adding John here. John, any chance you could fire up dwc3 on HAPS and > see wether it works or fails for you ? >
Sure. I'll try to get to it tomorrow.
John
| |