Messages in this thread | | | Date | Mon, 29 Jun 2015 16:47:01 -0500 | From | Felipe Balbi <> | Subject | Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails |
| |
Hi,
On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wrote: > We need to return error to caller if command is not sent to > controller succesfully. > > Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com> > Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver) > Cc: <stable@vger.kernel.org> > --- > v2 changes: > Added Fixes and Cc in commit message.
I noticed that this breaks at least my AM437x silicon with DWC3 2.40a when used with g_zero and testusb. As of now, it could be that silicon is mis-behaving because I got a Transfer Complete before the failing Set Endpoint Transfer Resource command.
In any case, can you run on your setup with g_zero and test.sh/testusb [1]/[2] just to verify that it really works for you ?
Meanwhile, I'll continue testing on my end.
cheers
[1] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c81374aafb795c6e40:testusb.c [2] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c81374aafb795c6e40:test.sh
-- balbi [unhandled content-type:application/pgp-signature] | |