Messages in this thread | | | Date | Tue, 26 May 2015 11:35:19 -0500 | From | Timur Tabi <> | Subject | Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device |
| |
On 05/26/2015 03:28 AM, Hanjun Guo wrote:
>> early_acpi_os_unmap_memory((char *)table, tbl_size); >> } > > please add > > #ifdef CONFIG_ARM_SBSA_WATCHDOG > (acpi gtdt code) > #endif
I don't agree with this. The GTDT should be parsed even if there's no watchdog driver compiled for this kernel. There are no other #ifdefs in this file.
>> + * Add a platform device named "sbsa-gwdt" to match the platform >> driver. >> + * "sbsa-gwdt": SBSA(Server Base System Architecture) Generic >> Watchdog >> + * The platform driver can get device info below by matching this >> name. > > * The platform driver (drivers/watchdog/sbsa_gwdt.c) can get device info > below by matching this name. > > Adding the file name which will help for review and maintain in my > opinion.
Except it will cause problems if the driver is renamed or moved. I don't think this is a good idea, either (sorry!)
-- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |