Messages in this thread | | | Date | Tue, 26 May 2015 11:24:03 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device |
| |
On Tue, May 26, 2015 at 11:35:19AM -0500, Timur Tabi wrote: > On 05/26/2015 03:28 AM, Hanjun Guo wrote: > > >> early_acpi_os_unmap_memory((char *)table, tbl_size); > >> } > > > >please add > > > >#ifdef CONFIG_ARM_SBSA_WATCHDOG > >(acpi gtdt code) > >#endif > > I don't agree with this. The GTDT should be parsed even if there's no > watchdog driver compiled for this kernel. There are no other #ifdefs in > this file. >
Me not either, but then I thought this is really a maintainer question. If the maintainers want out-of-subsystem #ifdefs in the code, who am I to complain.
Should be "#if IS_ENABLED(CONFIG_ARM_SBSA_WATCHDOG)", though, if we go along that route.
Guenter
| |