Messages in this thread | | | Date | Tue, 26 May 2015 22:08:14 -0500 | From | Timur Tabi <> | Subject | Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device |
| |
Hanjun Guo wrote: >> I don't agree with this. The GTDT should be parsed even if there's no >> watchdog driver compiled for this kernel. There are no other #ifdefs in >> this file. > > So what's the point of parse GTDT and alloc memories for it if there > is no watchdog driver compiled for the kernel?
I don't think it's normal policy to generate a platform only if one specific driver is enabled.
> will the module insmod > later even if the CONFIG_ARM_SBSA_WATCHDOG=n?
I think that actually can work, but it's not a good reason by itself.
> OK, that's good point. but what I proposed is some hint to which driver > will use the data prepared in this file, we can easily understand it > in this patchset, but if just review the code in this fiel, I think > people will be confused without detail comments.
All anyone needs to is
git grep "sbsa-gwdt"
And you'll find the driver.
-- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.
| |