Messages in this thread | | | Date | Tue, 26 May 2015 13:28:58 +0100 | From | Will Deacon <> | Subject | Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device |
| |
On Mon, May 25, 2015 at 11:03:13AM +0100, fu.wei@linaro.org wrote: > From: Fu Wei <fu.wei@linaro.org> > > Parse SBSA Generic Watchdog Structure in GTDT table of ACPI, > and create a platform device with that information. > This platform device can be used by the ARM SBSA Generic > Watchdog driver. > > Tested-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> > Tested-by: Timur Tabi <timur@codeaurora.org> > Signed-off-by: Fu Wei <fu.wei@linaro.org> > --- > arch/arm64/kernel/acpi.c | 145 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 145 insertions(+)
Why does this all need to be under arch/arm64? The GTDT really isn't architecture-specific, so I'd *much* rather it was parsed in the driver code itself, like we already do for the architected timer. The GIC is an exception because it's in the MADT, which we need to parse in the arch code to configure SMP properly.
Will
| |